Skip to content

chore: update default script examples #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 13, 2025
Merged

chore: update default script examples #1279

merged 6 commits into from
Oct 13, 2025

Conversation

@peterschretlen
Copy link
Contributor

@peterschretlen peterschretlen commented Oct 3, 2025 •
edited
Loading

What this PR does / why we need it:

This PR updates the default scripted and browser examples to:

  • Use quickpizza login as the example for both scripts
  • Advertise k6 studio for recording browser scripts
  • Advertise secrets management
  • Modernize by replacing fail with expect (assertions library)

Which issue(s) this PR fixes:

Fixes https://github.com/grafana/synthetic-monitoring/issues/358

My main concern is this makes the default scripts longer and harder to read.

Scripted Before
image

Scripted After
image

Browser Before
image

Browser After
image

@peterschretlen peterschretlen requested a review from a team as a code owner October 3, 2025 22:26
@github-actions
Copy link

github-actions bot commented Oct 3, 2025 •
edited
Loading

Script size changes

Name +/- Main This PR Outcome
[module.js] +0.08% 2,386.30 kB 2,388.15 kB ✅
[datasource/module.js] = 24.68 kB 24.68 kB ✅

Totals

Name +/- Main This PR Outcome
[Scripts] +0.08% 2,410.98 kB 2,412.83 kB ✅
[Non-script Assets] = 2,587.82 kB 2,587.82 kB ✅
[All] +0.04% 4,998.80 kB 5,000.64 kB ✅

Generated by 🚫 dangerJS against f013ef8

w1kman
w1kman reviewed Oct 3, 2025
View reviewed changes
w1kman
w1kman reviewed Oct 3, 2025
View reviewed changes
@peterschretlen peterschretlen requested a review from w1kman October 8, 2025 17:38
ckbedwell
ckbedwell approved these changes Oct 13, 2025
View reviewed changes
Copy link
Contributor

@ckbedwell ckbedwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckbedwell ckbedwell merged commit eb39e8f into main Oct 13, 2025
23 checks passed
@ckbedwell ckbedwell deleted the add-secrets-to-examples branch October 13, 2025 10:15
@sm-release-app sm-release-app bot mentioned this pull request Oct 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckbedwell ckbedwell ckbedwell approved these changes

@w1kman w1kman Awaiting requested review from w1kman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peterschretlen @w1kman @ckbedwell